[tor-bugs] #24001 [Core Tor/Tor]: node_get_ed25519_id() should check if the microdesc ed25519 id is all zero

[Tor Bug Tracker & Wiki]

#24001: node_get_ed25519_id() should check if the microdesc ed25519 id is all zero
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy intro    |  Actual Points:
Parent ID:  #23975        |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by aruna1234):

 Replying to [comment:6 teor]:
 > I think it would be a good idea to check both the ri and md ed25519 ids
 to see if the memory they point to is zero.
 >
 > Can you copy the check from the ri ed25519 id to the md ed25519 id?
 also did this,

 if (BUG(ed25519_public_key_is_zero(md_pk)))
         md_pk = NULL;
 this is passing all tests when I run a make check

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24001#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online