[tor-bugs] #24637 [Obfuscation/BridgeDB]: moat: incorrect response if no bridges available

[Tor Bug Tracker & Wiki]

#24637: moat: incorrect response if no bridges available
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  isis
     Type:  defect                               |         Status:  closed
 Priority:  Immediate                            |      Milestone:
Component:  Obfuscation/BridgeDB                 |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  bridgedb-moat, bridgedb-             |  Actual Points:
  distributors                                   |
Parent ID:  #24689                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorV
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  new => closed
 * priority:  Medium => Immediate
 * points:   => 1
 * sponsor:   => SponsorV
 * keywords:   => bridgedb-moat, bridgedb-distributors
 * resolution:   => fixed


Comment:

 Fixed in my `fix/24637`
 [https://gitweb.torproject.org/user/isis/bridgedb.git/log/?h=fix/24637
 branch], which includes the following small spec change specifying the
 error:

 {{{
  If the ``SOLUTION`` was successful for the supplied ``CHALLENGE``, but
 the
  server is unable to distribute the requested Bridges, the server responds
 ``200
  OK`` with the following JSON::

      {
 -      "error": {
 -        "id": "1",
 +      "errors": [{
 +        "id": "6",
 +        "type": "moat-bridges",
 +        "version": "0.1.0",
          "code": "404",
          "status": "Not Found",
 -        "title": "Could not fetch the type of bridges you requested",
          "detail": "DETAILS",
 -      }
 +      }]
      }

  where:

  * ``DETAILS`` is some string describing the detailed nature of the issue.

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24637#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online