[tor-bugs] #21847 [Applications/Tor Browser]: Update copy for security slider to be consistent with the mobile experience
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Dec 15 15:08:24 UTC 2017
#21847: Update copy for security slider to be consistent with the mobile experience
-------------------------------------------------+-------------------------
Reporter: isabela | Owner: tbb-
| team
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-usability, tbb-security-slider, | Actual Points:
TorBrowserTeam201712R, GeorgKoppen201712 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by mcs):
The followup patch looks good to me.
I did notice a small issue today when I ran with the new code on macOS:
when the Security Settings window first opens, nthe "Learn More" link has
the keyboard focus. I suppose that is just default XUL behavior (set focus
to the first element that can have a keyboard focus), but it looks a
little strange because macOS draws a box around the link. If you think
this is worth fixing, the following addition to
`torbutton_init_security_ui()` fixes it:
{{{
let okBtn = document.documentElement.getButton("accept");
if (okBtn)
okBtn.focus();
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21847#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list