[tor-bugs] #24610 [Core Tor/Tor]: assertion !(status == HS_CLIENT_FETCH_HAVE_DESC) failed

[Tor Bug Tracker & Wiki]

#24610: assertion !(status == HS_CLIENT_FETCH_HAVE_DESC) failed
-----------------------------+------------------------------------
 Reporter:  cypherpunks      |          Owner:  (none)
     Type:  defect           |         Status:  new
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:  Tor: 0.3.2.1-alpha
 Severity:  Normal           |     Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------

Comment (by asn):

 Replying to [comment:4 dgoulet]:
 > We shouldn't think comment:2 is accurate also. After working on this, a
 simpler edge-case to trigger this became apparent so what you describe is
 really what should be considered as "the problem" of this ticket.
 >
 > > The first commit should fix this scenario because now
 can_client_refetch_desc() will return HS_CLIENT_FETCH_PENDING instead of
 HS_CLIENT_FETCH_HAVE_DESC. I wonder if there are any other such weird
 edge-cases this patch won't fix :S
 >
 > As you noticed, I left the BUG() there and even added a non fatal assert
 so if this is triggered again, we can investigate more. At least, in both
 cases, the tor client is fine and recovers.
 >

 Sounds reasonable. Let's see if we can find a way to test this well.

 If not testable robustly, we should consider whether we want to merge this
 in the last -rc, or just leave it for 033. This seems like a pretty wild
 edge-case so delaying might not be terrible.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24610#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online