[tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
----------------------------------+--------------------------
 Reporter:  isis                  |          Owner:  isis
     Type:  defect                |         Status:  closed
 Priority:  High                  |      Milestone:
Component:  Obfuscation/BridgeDB  |        Version:
 Severity:  Normal                |     Resolution:  fixed
 Keywords:  bridgedb-dist moat    |  Actual Points:  1
Parent ID:                        |         Points:  1
 Reviewer:                        |        Sponsor:  SponsorM
----------------------------------+--------------------------

Comment (by mcs):

 Replying to [comment:8 isis]:
 > > * The `data` payload is specified as an object but the implementation
 uses an array. This is permitted by the JSON API specification but seems
 unnecessary for the moat protocol (since each request and response only
 includes one JSON object).
 >
 > We can change it back to a single object if you think that's better. My
 reasoning was:
 >
 > 1. I totally read the spec wrong and I thought it said they had to be
 arrays, and
 > 2. future-compatibility, in case we decided at some point that providing
 the user with more messages/errors might be helpful (e.g. if there is some
 non-fatal error which we might want to return/log/display on the client-
 side, but we're still also going to return bridges/captchas).

 My argument is that using arrays just makes the code a little more
 complicated, and on the client side we are always going to send a one-
 element array for requests and we are going to use data[0] when handling
 each response. But let's just use arrays since that is what is already
 implemented.

 Please update the spec when you have time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24433#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online