[tor-bugs] #24572 [Core Tor/Tor]: rewrite_node_address_for_bridge() doesn't set rs IPv6 addresses

[Tor Bug Tracker & Wiki]

#24572: rewrite_node_address_for_bridge() doesn't set rs IPv6 addresses
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.2.4.5-alpha
     Severity:  Normal        |   Keywords:  ipv6, easy. intro
Actual Points:                |  Parent ID:  #20916
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 rewrite_node_address_for_bridge() should set the IPv6 address in rs, as
 well as setting the one in ri. We can copy the code from ri.

 This goes back to commit 9e9edf71f7d in tor 0.2.4.5-alpha.

 This is unlikely to have caused any bugs since at least 0.2.8, because
 node_get_*_or_addr() checks the ri before the rs.

 But let's fix it anyway, for consistency and better logging.

 (Eventually, we will rip out this code when we make ri and rs read-only.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24572>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online