[tor-bugs] #23966 [Core Tor/Tor]: Refactor node_has_curve25519_onion_key() to use node_get_curve25519_onion_key()

[Tor Bug Tracker & Wiki]

#23966: Refactor node_has_curve25519_onion_key() to use
node_get_curve25519_onion_key()
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  (none)
     Type:  defect          |         Status:  new
 Priority:  Medium          |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  easy, refactor  |  Actual Points:
Parent ID:                  |         Points:  0.2
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:2 aruna1234]:
 > could you give more information?

 These functions have code that's almost identical.
 We can implement node_has… by calling node_get… and checking the result.
 The result is valid if it passes the existing check in node_has….

 This might be a good ticket for you to focus on, because it is a small
 first-time change for you to learn C and learn our processes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23966#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online