[tor-bugs] #12418 [Applications/Tor Browser]: TBBs with UBSan create lots of errors when running

[Tor Bug Tracker & Wiki]

#12418: TBBs with UBSan create lots of errors when running
------------------------------------------------+--------------------------
 Reporter:  gk                                  |          Owner:  tbb-team
     Type:  defect                              |         Status:  assigned
 Priority:  Medium                              |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tbb-security, TorBrowserTeam201711  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------

Comment (by arthuredelstein):

 As a status report: I have started work on trying to fix ubsan runtime
 errors in Firefox and Tor Browser. Here's my script to download all log
 files from the Mozilla task cluster, and extract, deduplicate, and
 categorize the ubsan errors from a try server run:
 https://github.com/arthuredelstein/firefox-ubsan-errors

 I decided to first focus on he category of ubsan enum errors as a proof of
 principle. Here's the parent ticket:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1404547

 I opened and fixed the following tickets:

 * https://bugzilla.mozilla.org/1404174
 * https://bugzilla.mozilla.org/1404224
 * https://bugzilla.mozilla.org/1404226
 * https://bugzilla.mozilla.org/1404570
 * https://bugzilla.mozilla.org/1404572
 * https://bugzilla.mozilla.org/1405139
 * https://bugzilla.mozilla.org/1405154
 * https://bugzilla.mozilla.org/1405156

 I also opened the following tickets:
 * https://bugzilla.mozilla.org/1404169 (fixed by Paul Adenot)
 * https://bugzilla.mozilla.org/1404189 (fixed by André Bargull)

 There remain four more ubsan enum error locations. I expect two of these
 can be fixed, and the other two will need to be whitelisted using `-fno-
 sanitize=enum`. Then we can add `-fsanitize=enum` for the overall
 Firefox/TBB debug build.

 Then the next steps will be to fix other types of ubsan runtime errors and
 then turn on aborts for them in the debug builds so that future ubsan
 errors can be discovered during automated test runs.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12418#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online