[tor-bugs] #23603 [Core Tor/Tor]: hs: Cleanup race between circuit close and free with the HS circuitmap

[Tor Bug Tracker & Wiki]

#23603: hs: Cleanup race between circuit close and free with the HS circuitmap
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  asn           |        Sponsor:
--------------------------+------------------------------------

Comment (by asn):

 Hello, LGTM.

 I pushed a branch `bug23603_032_01` on my repo that tries to tidy up the
 HS circuit cleanup  operation by pulling it into a function, so that we
 don't pollute the `circuit_free()` and `circuit_mark_for_close()`
 functions with various HS-specific stuff. Let me know if you like it, and
 if you like it a lot squash it up, and put it in `merge_ready`. Cheers!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23603#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online