[tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342           |         Points:
 Reviewer:  catalyst         |        Sponsor:
-----------------------------+------------------------------------

Comment (by catalyst):

 gcc Travis builds failed (after fixing up two unresolved merge conflicts
 in test_buffers.c):

 {{{
 In file included from src/common/buffers_tls.c:10:0:
 src/common/buffers.h:70:27: error: ‘preferred_chunk_size’ declared
 ‘static’ but never defined [-Werror=unused-function]
  ATTR_UNUSED STATIC size_t preferred_chunk_size(size_t target);
                            ^
 cc1: all warnings being treated as errors
 make: *** [src/common/buffers_tls.o] Error 1
 make: *** Waiting for unfinished jobs....
 }}}

 It looks like buffers_tls.c defines `BUFFERS_PRIVATE` but doesn't provide
 a `STATIC` definition of `preferred_chunk_size()`.  (though it would
 probably cause duplicate definitions when built with `-DTOR_UINIT_TESTS`)

 I'm not sure what's best here; maybe a different macro to protect the
 `STATIC` declaration in buffers.h?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23149#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online