[tor-bugs] #22802 [Core Tor/Tor]: Avoid use of "0" with tor_parse_foo()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Aug 28 11:22:01 UTC 2017
#22802: Avoid use of "0" with tor_parse_foo()
-----------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: review-group-22 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+------------------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
Seems like we added a forgotten
{{{
+ // ????
}}}
in `parse_process_specifier()`.
Also if we are serious about this, should we add an
`tor_assert_nonfatal(base > 0)` in `tor_parse_long()` to make sure that we
don't do this mistake in the future?
Other than that, patch looks good to me!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22802#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list