[tor-bugs] #21759 [Metrics/CollecTor]: Add persistence for torperf/onionperf

[Tor Bug Tracker & Wiki]

#21759: Add persistence for torperf/onionperf
-------------------------------+-----------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_information
 Priority:  Medium             |      Milestone:  CollecTor 1.4.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+-----------------------------------
Changes (by iwakeh):

 * status:  needs_revision => needs_information


Comment:

 The following is still open and needs info:

 > Common approach for storing:
 > It turns out that the functionality in OnionperfDownloader was too
 restrictive.
 > Here's an overview:
 > - bridge-desc (all types): after sanitation the descriptor is written;
 if one descriptor cannot be sanitized, it is skipped
 > - relay-desc (all types): descriptors written one by one skipping
 problematic ones
 > - exitlists: always stored as a single file.
 >
 > Solution: if a single TorperfResult is not parseable, it should simply
 be skipped as in the sync-implementation.
 >


 The second part:
 > Another topic, which relates to comment:7:
 > Currently, all synced descriptors receive their annotation from the
 Annotation enum (cf. package o.t.c.conf.Annotation).  This happens,
 because only the raw bytes are taken from a given descriptor and written
 to the file system.
 > But, actually the annotation(s) should be taken from the
 'getAnnotations' method and be prepended to the raw descriptor bytes,
 shouldn't they?
 > ...

 is now a new ticket #23215.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21759#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online