[tor-bugs] #22047 [Metrics/Atlas]: Remove usage of the data-original-title attribute
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sun Apr 23 20:08:21 UTC 2017
#22047: Remove usage of the data-original-title attribute
-------------------------------+-----------------
Reporter: cypherpunks | Owner: irl
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Metrics/Atlas | Version:
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
-------------------------------+-----------------
The HTML in Atlas uses the data-original-title attribute which serves no
purpose other than to clutter up the code. FWICT this is left over code
from when Atlas used the Bootstrap Popover plugin which was removed in
commit
[https://gitweb.torproject.org/atlas.git/commit/?id=7a0ee0c7e69b10c33d671395f17c9cf8664bd2f9
7a0ee0c7e69b10c33d671395f17c9cf8664bd2f9].
The Bootstrap Tooltip plugin overwrites the data-original-title attribute
when the title attribute is specified in the
[https://gitweb.torproject.org/atlas.git/tree/js/libs/bootstrap/bootstrap-
tooltip.js?id=a2b3f23f0212a16ae410d513749b535fdbe6bc5a#n191 fixTitle
function]. In the current code base all elements that use the data-
original-title attribute also specify the title attribute so the former
serves no purpose.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22047>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list