[tor-bugs] #21967 [Core Tor/Tor]: obfs4proxy not killed when unused

[Tor Bug Tracker & Wiki]

#21967: obfs4proxy not killed when unused
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-pt        |  Actual Points:
Parent ID:                |         Points:  1.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Replying to [comment:4 yawning]:
 > Removing Bridges with `RESETCONF` doesn't seem to affect `bridge_list`
 at the time when pts would be torn down either.

 Check out this code in config.c:
 {{{
   if (options->Bridges) {
     mark_bridge_list();
     for (cl = options->Bridges; cl; cl = cl->next) {
       bridge_line_t *bridge_line = parse_bridge_line(cl->value);
       if (!bridge_line) {
         log_warn(LD_BUG,
                  "Previously validated Bridge line could not be added!");
         return -1;
       }
       bridge_add_from_config(bridge_line);
     }
     sweep_bridge_list();
   }
 }}}

 If we moved the mark and sweep to outside the if, then we would clear out
 bridge_list in the case where options->Bridges is 0. That seems wise.

 Or if we prefered, we could start this stanza with
 {{{
   if (!options->Bridges) {
     clear_bridge_list();
   } else {
     ...
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21967#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online