[tor-bugs] #17868 [Core Tor/Tor]: base64_decode_nopad() destination buffer length problem

[Tor Bug Tracker & Wiki]

#17868: base64_decode_nopad() destination buffer length problem
-----------------------------+------------------------------------
 Reporter:  dgoulet          |          Owner:  nikkolasg
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-12  |  Actual Points:
Parent ID:  #19531           |         Points:  2
 Reviewer:  dgoulet          |        Sponsor:  SponsorR-can
-----------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_revision => needs_review


Comment:

 Proposed (somewhat more minimalist) fix in
 https://gitlab.com/argonblue/tor/merge_requests/3
 This deletes `base64_decode_nopad()`, makes `base64_decode()` check the
 actual decoded length instead of making an overly conservative estimate,
 and removes the now-obsolete `SR_COMMIT_LEN` workaround in #16943.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17868#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online