[tor-bugs] #21894 [Core Tor/Tor]: Base32_encode: *actually* allow inputs of odd sizes

[Tor Bug Tracker & Wiki]

#21894: Base32_encode: *actually* allow inputs of odd sizes
---------------------------------------+-----------------------------------
 Reporter:  nickm                      |          Owner:  nickm
     Type:  defect                     |         Status:  needs_review
 Priority:  High                       |      Milestone:  Tor:
                                       |  0.3.1.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  029-backport 030-backport  |  Actual Points:  .1
Parent ID:                             |         Points:  .1
 Reviewer:                             |        Sponsor:  SponsorR-can
---------------------------------------+-----------------------------------

Comment (by catalyst):

 When bits = {0, 10, 25} mod 40, the same byte gets loaded into high and
 low halves of the 16-bit word we're assembling in `v`, but the right-shift
 of `11-(bits%8)` is greater than 8 bits, so we discard the low byte.
 (which might be the same thing you're saying in different words?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21894#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online