[tor-bugs] #21890 [Metrics/metrics-lib]: Don't skip unrecognized lines in certain cases

[Tor Bug Tracker & Wiki]

#21890: Don't skip unrecognized lines in certain cases
-------------------------------------+--------------------------
     Reporter:  karsten              |      Owner:  metrics-team
         Type:  defect               |     Status:  new
     Priority:  Medium               |  Milestone:
    Component:  Metrics/metrics-lib  |    Version:
     Severity:  Normal               |   Keywords:
Actual Points:                       |  Parent ID:
       Points:                       |   Reviewer:
      Sponsor:                       |
-------------------------------------+--------------------------
 When we started using Java 7's switch-on-String in 2b4d773, we broke
 unrecognized line parsing in extra-info descriptors.  Namely, when we
 reached the end of a crypto block we didn't reset the list for collecting
 crypto lines.  So far so good, but any following unrecognized lines would
 be collected as crypto lines and later discarded, rather than being added
 to the unrecognized-lines list and later reported.

 This only affects relay descriptors, because sanitized bridge descriptors
 don't contain crypto blocks.  And it only affects relay descriptors with
 crypto blocks, like "identity-ed25519", whereas relay extra-info
 descriptors published by older versions were not affected.

 Branch follows in a second.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21890>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online