[tor-bugs] #16706 [Core Tor/Tor]: Too many connection_edge_process_relay_cell warnings

[Tor Bug Tracker & Wiki]

#16706: Too many connection_edge_process_relay_cell warnings
-------------------------------------------------+-------------------------
 Reporter:  s7r                                  |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.6.10
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, nickm-deferred-20161017,     |  Actual Points:
  triage-out-030-201612                          |
Parent ID:                                       |         Points:  3
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorR-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 Very small fix for this which is to not print the warning if an invalid
 hidden service port is requested. As far as I can tell, it's the only case
 where the reason `END_CIRC_AT_ORIGIN` is returned in that code path.

 It's not an ideal fix I would say but it's that or a *massive* refactoring
 of `connection_edge_process_relay_cell()` and how it's used.

 Now, with `ProtocolWarnings 1`, you see this and set to 0, the warning
 line is not present.

 {{{
 Apr 05 16:22:53.000 [info] rend_service_set_connection_addr_port(): No
 virtual port mapping exists for port 18163 on service bdf2bzs2od7ynr33
 Apr 05 16:22:53.000 [info] connection_exit_begin_conn(): Didn't find
 rendezvous service (port 18163)
 Apr 05 16:22:53.000 [warn] circuit_receive_relay_cell (backward) failed.
 Closing.
 }}}

 See branch: `bug16706_031_01`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16706#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online