[tor-bugs] #13339 [Core Tor/Tor]: Prop140: Complete Consensus diffs / Merge GSoC project

[Tor Bug Tracker & Wiki]

#13339: Prop140: Complete Consensus diffs / Merge GSoC project
-------------------------------------------------+-------------------------
 Reporter:  mvdan                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7
 Severity:  Normal                               |     Resolution:
 Keywords:  gsoc, merge, tor-client, prop140,    |  Actual Points:
  027-triaged-1-in, 028-triaged, pre028-patch,   |
  tor-dos, low-bandwidth, nickm-                 |
  deferred-20160905, tor-03-unspecified-201612,  |
  sponsor4, TorCoreTeam201703                    |
Parent ID:                                       |         Points:  parent
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by Sebastian):

 Hi Daniel, great that you're still around :) I have a question about the
 unit tests. In the function test_consdiff_calc_changes() in the second
 test, you're calculating the changes between "a\na\na\na\n" and
 "a\nb\na\nb\n" - and then we expect the first bit vector to be marked
 unchanged, changed, changed, unchanged. What am I missing here? According
 to the documentation of calc_changes() I would think that the proper
 result would be unchanged, changed, unchanged, changed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13339#comment:55>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online