[tor-bugs] #20191 [Core Tor/Tor]: Prevent a recurrence of #20103

Tue Sep 20 23:34:02 UTC 2016

#20191: Prevent a recurrence of #20103
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.9.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  .2            |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 On #20103, Roger sensibly asks:
 > Assuming for the moment that it is the right patch though: are there
 things we should do to remove this trap for future developers? Maybe a
 huge comment would be an easy first step? And maybe "precompute the answer
 to what that macro was about, and locate where in the code the answer
 might change, and only change it then" as another step?

 Yes, let's.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20191>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online