[tor-bugs] #20147 [Applications/Tor Browser]: [PATCH] (re-)dzip.sh: various improvements

Tue Sep 20 21:09:23 UTC 2016

#20147: [PATCH] (re-)dzip.sh: various improvements
-----------------------------------------------+---------------------------
 Reporter:  rustybird                          |          Owner:  tbb-team
     Type:  enhancement                        |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201609R  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by mcs):

 I reviewed this and have a couple of comments on the re-dzip.sh changes.

 It would be better to use a temporary directory name that is likely to be
 unique,
 e.g., `TMPDIR=tmp-re-dzip-$$`

 Also, shouldn't this line: `(cd tmp_dzip; dzip.sh ./"$ZIPFILE_BASENAME")`
 include a dot like so: `(cd tmp_dzip; dzip.sh ./"$ZIPFILE_BASENAME" .)`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20147#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online