[tor-bugs] #20176 [Core Tor/Tor]: current_consensus is an unmarked hazard

[Tor Bug Tracker & Wiki]

#20176: current_consensus is an unmarked hazard
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.9.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  .1            |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 current_md_consensus is a static variable.
 current_ns_consensus is a static variable.

 {{{
 #define current_consensus                                       \
   (we_use_microdescriptors_for_circuits(get_options()) ?        \
    current_md_consensus : current_ns_consensus)
 }}}

 We should at the very least rename this to a CURRENT_CONSENSUS macro.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20176>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online