[tor-bugs] #18093 [Applications/Tor Browser]: Torbutton UI flow improvement

[Tor Bug Tracker & Wiki]

#18093: Torbutton UI flow improvement
-------------------------------------------------+-------------------------
 Reporter:  bugzilla                             |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-usability, tbb-torbutton, tbb-   |  Actual Points:
  security-slider, TorBrowserTeam201609          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_information => needs_revision


Comment:

 Replying to [comment:10 arthuredelstein]:
 > Here's a patch for review that implements option (1), and defers
 applying the settings until the OK button is pressed:
 > https://github.com/arthuredelstein/torbutton/commit/18093

 Kathy and I reviewed this and have a few comments:
 1. The implementation of torbutton_reset_browser_prefs() should be removed
 since that function is no longer used.
 2. You need to pass `document` to the revised
 `torbutton_prefs_reset_defaults()` function.
 3. Normally, when the user tries to check or uncheck the
 torbutton_blockDisk checkbox, a "Restart Tor Browser?" prompt is
 displayed. If "Restore Defaults" modifies that pref, the same prompt
 should be displayed. I think this problem exists without your changes
 though.

 (For 1. and 2., maybe you just forgot to include your preferences.xul and
 torbutton.js changes).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18093#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online