[tor-bugs] #20063 [Core Tor/Tor]: Permit sched_yield in sandbox

[Tor Bug Tracker & Wiki]

#20063: Permit sched_yield in sandbox
----------------------------+------------------------------------
 Reporter:  nickm           |          Owner:  nickm
     Type:  defect          |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  review-group-8  |  Actual Points:  0
Parent ID:                  |         Points:  0
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------

Comment (by nickm):

 > Hmm, is there a way to reproduce this problem, so that we can test the
 fix?

 That's going to depend on your exact asan implementation; GCC and Clang
 are different a lot, and different versions of each will differ from one
 another.  I think I ran into this problem with the asan from GCC 6.1.1.

 > Should we only whitelist those syscalls if and only if ASAN is enabled?
 Because IIUC, now they are whitelisted for all builds.

 I think the calls are harmless, and we can just whitelist them generally,
 but I wouldn't mind if somebody had a look.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20063#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online