[tor-bugs] #19969 [Core Tor/Tor]: tor client does not immediately open new circuits after standby

[Tor Bug Tracker & Wiki]

#19969: tor client does not immediately open new circuits after standby
--------------------------+------------------------------------
 Reporter:  weasel        |          Owner:
     Type:  defect        |         Status:  new
 Priority:  High          |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.8.6
 Severity:  Normal        |     Resolution:
 Keywords:  regression    |  Actual Points:
Parent ID:                |         Points:  2
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Replying to [comment:10 arma]:
 > My investigations led me to be suspicious of Tor commit {{{b1d56fc58}}}.
 > [...]
 > Then {{{run_main_loop_once()}}} calls
 {{{connection_ap_attach_pending(0)}}}, which goes through and calls
 {{{connection_ap_handshake_attach_circuit()}}} on each stream that needs
 it.
 >
 > But when I gdb attach to my unhappy Tor client and set a breakpoint on
 {{{connection_ap_attach_pending}}} and then do a new socks request, it
 seems that it never calls the function!

 Still suspicious of commit {{{b1d56fc58}}}.

 Is it possible that event_base_loop() in run_main_loop_once() is never
 finishing for me? After all, it has a bunch of callbacks, like
 second_elapsed_callback() and check_descriptor_callback() and so on, which
 all schedule themselves to get put back in the queue once they're done.
 Does this event_base_loop function keep running until there are no more
 events?

 I see some ways it can choose to finish, like if flags is non-zero, or if
 connection_start_reading_from_linked_conn() calls
 tor_event_base_loopexit(), but neither of those apply to me here.

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/19969#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online