[tor-bugs] #20284 [Core Tor/Tor]: consensus weight case 2b3 does not follow dir-spec

[Tor Bug Tracker & Wiki]

#20284: consensus weight case 2b3 does not follow dir-spec
-----------------------------+------------------------------------
 Reporter:  pastly           |          Owner:  pastly
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-11  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------

Comment (by pastly):

 I've made the changes nickm suggests on this new branch.

 https://github.com/pastly/public-tor/tree/ticket20284-v2

 Maybe it's just me, but my changes seem rather ugly. I think it's because
 I want to keep the structure of the code matching dir-spec so one can read
 along.

 I'm wide open for suggestions if others feel this isn't merge-able.

 We also haven't heard from mikeperry yet about his thoughts regarding code
 vs. dir-spec.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20284#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online