[tor-bugs] #20048 [Core Tor/Tor]: Introduce `smartlist_add_strdup()` function
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Oct 24 11:07:57 UTC 2016
#20048: Introduce `smartlist_add_strdup()` function
--------------------------+------------------------------------
Reporter: asn | Owner:
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: easy | Actual Points:
Parent ID: | Points: 0.3
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by icanhasaccount):
Thank you for checking and for the feedback - I'll break the diff up into
parts with a change file.
Re the shortening thing - I explained that really badly. When reviewing
the diff I noticed there are a few places (mostly in the test directory)
where the pattern is:
char *foo = tor_strdup("bar");
....
smartlist_add(sl, foo);
By shortening I meant I could go through and change those to use
smartlist_add_strdup where appropriate afterwards.
Thanks again for your patience/help!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20048#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list