[tor-bugs] #20376 [Core Tor/Tor]: Do not mark circs for close again after relay_send_command_from_edge()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sun Oct 16 21:19:45 UTC 2016
#20376: Do not mark circs for close again after relay_send_command_from_edge()
--------------------------+------------------------------
Reporter: twim | Owner:
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version:
Severity: Minor | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------
Comment (by twim):
Hmm, haven't noticed before that `relay_send_command_from_edge_()` also
can return non-zero value here:
{{{
if (cpath_layer) {
cell.circ_id = circ->n_circ_id;
cell_direction = CELL_DIRECTION_OUT;
} else if (! CIRCUIT_IS_ORIGIN(circ)) {
cell.circ_id = TO_OR_CIRCUIT(circ)->p_circ_id;
cell_direction = CELL_DIRECTION_IN;
} else {
return -1;
}
}}}
Should it mark such circ to close here?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20376#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list