[tor-bugs] #18529 [Core Tor/Tor]: Fix duplicate check for "only allow internal addresses if we are on a network with nonstandard authorities"

[Tor Bug Tracker & Wiki]

#18529: Fix duplicate check for "only allow internal addresses if we are on a
network with nonstandard authorities"
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.1-alpha
 Severity:  Trivial                              |     Resolution:
 Keywords:  easy, refactor, 029-nickm-says-yes,  |  Actual Points:
  review-group-3, nickm-deferred-20160905        |
Parent ID:                                       |         Points:  1
 Reviewer:  isis                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  needs_review => merge_ready
 * milestone:  Tor: 0.2.??? => Tor: 0.2.9.x-final


Comment:

 LGTM. FWIW, we could still probably add do call to
 `is_default_directory_auth()` inside `tor_addr_is_internal()`, for further
 condensation, but it's not vital.

 Nick: This should be a very safe patch to merge into 0.2.9, because it
 functionally doesn't change anything, if you're okay with that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18529#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online