[tor-bugs] #20217 [Applications/Tor Browser]: Make sure that all .mar files required for generating incremental ones on OS X contain code-signed bits
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Oct 10 17:58:06 UTC 2016
#20217: Make sure that all .mar files required for generating incremental ones on
OS X contain code-signed bits
-----------------------------------------------+---------------------------
Reporter: gk | Owner: tbb-team
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-gitian, TorBrowserTeam201610R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------------------------+---------------------------
Changes (by boklm):
* keywords: tbb-gitian, TorBrowserTeam201610 => tbb-gitian,
TorBrowserTeam201610R
* status: new => needs_revision
Comment:
The branch `bug_20217` in my git repo has a patch for this:
https://gitweb.torproject.org/user/boklm/tor-browser-
bundle.git/commit/?h=bug_20217
When generating the OSX incremental MARs from `make dmg2mars` or `make
dmg2mars-alpha`, we are now checking that both the new and the old MAR
files contain a file in
`TorBrowser.app/Contents/_CodeSignature/CodeResources`.
I checked that it fails with an error when the mar file from the old
version is not code signed.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20217#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list