[tor-bugs] #13827 [Core Tor/Tor]: Cell handling code duplication in channel.c
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Oct 7 12:43:29 UTC 2016
#13827: Cell handling code duplication in channel.c
-----------------------------------------------+---------------------------
Reporter: rl1987 | Owner: pingl
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: refactoring, easy, review-group-9 | Actual Points:
Parent ID: | Points: 0.1
Reviewer: dgoulet | Sponsor:
-----------------------------------------------+---------------------------
Comment (by pingl):
Ok, that makes sense. I didn't want to swap the order of the check on
`CHANNEL_IS_CLOSING(chan)` and `q.type = ...`
This makes everything easier. Just fix that and I'll commit the new
version.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13827#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list