[tor-bugs] #18357 [Core Tor/Tor]: HiddenServicePort IPv6 broken

[Tor Bug Tracker & Wiki]

#18357: HiddenServicePort IPv6 broken
--------------------------+------------------------------------
 Reporter:  sega01        |          Owner:  nickm
     Type:  defect        |         Status:  accepted
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.6.10
 Severity:  Normal        |     Resolution:
 Keywords:  ipv6, tor-hs  |  Actual Points:  .1
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:  SponsorR-can
--------------------------+------------------------------------
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted
 * actualpoints:   => .1


Comment:

 I think that the problem lies in the test in conmnection_exit_connect().
 The parentheses are wrong. We should allow rendezvous connections to IPv6
 addresses even when IPv6Exit is false, right?

 I've tried rewriting this test to be correct and easier to read; please
 review and test my branch bug18357?

 (This code is not tested.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18357#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online