[tor-bugs] #14881 [Core Tor/Tor]: incorrect defaults when producing bandwidth-weights line in directory footer

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Oct 1 00:35:14 UTC 2016


#14881: incorrect defaults when producing bandwidth-weights line in directory
footer
-------------------------------------------------+-------------------------
 Reporter:  robgjansen                           |          Owner:  pastly
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7
 Severity:  Normal                               |     Resolution:
 Keywords:  027-triaged-1-in, 028-triaged,       |  Actual Points:
  pre028-patch, tor-sponsorU-orphan,             |
  TorCoreTeam-postponed-201604, review-group-9   |
Parent ID:                                       |         Points:  3
 Reviewer:  mikeperry                            |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------

Comment (by teor):

 Thanks for running the chutney tests.

 To write a unit test for `networkstatus_compute_bw_weights_v10`, you can
 add a function to `src/test/test_dir.c`, using the existing tests as an
 example.

 Write a tests to exercise each of the cases in that function, and check
 that the results are as expected. (It would also be nice to write a test
 for the current values in a recent consensus.)

 The tor unit tests are run using:
 {{{
 make test
 }}}
 Or, for individual unit tests:
 {{{
 make src/test/test && src/test/test <name-of-test>
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14881#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list