[tor-bugs] #20835 [Core Tor/Tor]: Refactor choose_good_entry_server so it is (almost) never used

[Tor Bug Tracker & Wiki]

#20835: Refactor choose_good_entry_server so it is (almost) never used
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.0.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:  #20822
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 From my prop271 branch:
 {{{
  * XXXX prop271 this function is used in four ways: picking out guards for
  *   the old (pre-prop271) guard algorithm; picking out guards for
 circuits;
  *   picking out guards for testing circuits on non-bridgees;
  *   picking out entries when entry guards are disabled.  These options
  *   should be disentangled.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20835>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online