[tor-bugs] #20684 [Core Tor/Tor]: DIRCACHE_MIN_MB_BANDWIDTH is actually used for RAM

[Tor Bug Tracker & Wiki]

#20684: DIRCACHE_MIN_MB_BANDWIDTH is actually used for RAM
-----------------------------+------------------------------------
 Reporter:  teor             |          Owner:
     Type:  defect           |         Status:  new
 Priority:  Medium           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor     |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal           |     Resolution:
 Keywords:  easy intro typo  |  Actual Points:
Parent ID:                   |         Points:  0.1
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------

Comment (by teor):

 Hi Neel, thanks for the patch.

 Can you please rename them to:
 DIRCACHE_MIN_MEM and DIRCACHE_MIN_MB_MEM
 (There is no need to say "BANDWIDTH" at all, because it is confusing to
 say "BANDWIDTH" when talking about memory.)
 I am sorry I did not explain better in the ticket.
 Since these new names are shorter, there is no need to change the log
 messages to pass `make check-spaces`.

 Also, would you like to do a changes file for this one?
 Changes files help us make the changelog at the end of the release.
 You can say "patch by Neel Chauhan" at the end if you want.
 Here's how we do a changes file:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n56
 Or you can look at the one I made on your last ticket for an example.

 For the changes file, this bug was introduced in tor-0.2.8.1-alpha.

 I used `git blame` to find out this change was made in commit 997f779, and
 `git describe --contains 997f779` to find out the release for this commit
 was tor-0.2.8.1-alpha.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20684#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online