[tor-bugs] #20646 [Core Tor/Tor]: finish_writing_to_file_impl() should remove temporary file if replacing an existing one failed

[Tor Bug Tracker & Wiki]

#20646: finish_writing_to_file_impl() should remove temporary file if replacing an
existing one failed
-----------------------------+------------------------------------
 Reporter:  fk               |          Owner:
     Type:  defect           |         Status:  merge_ready
 Priority:  Medium           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor     |        Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-12  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 This seems logical to me as in the case of not being able to replace a
 file I guess there is no point at keeping the temporary file around.

 lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20646#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online