[tor-bugs] #20634 [Core Tor/Tor]: Unit test address/get_if_addrs6_list_no_internal should succeed if there are only internal addresses

[Tor Bug Tracker & Wiki]

#20634: Unit test address/get_if_addrs6_list_no_internal should succeed if there
are only internal addresses
-----------------------------+------------------------------------
 Reporter:  teor             |          Owner:
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor     |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal           |     Resolution:
 Keywords:  easy intro test  |  Actual Points:
Parent ID:                   |         Points:  0.1
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Replying to [comment:1 neel]:
 > I have created a patch for this. Tell me what you think about this.
 > ...

 Thanks for this patch, neel!

 Here's how I would make the patch better:
 * I would keep `expect_log_msg_containing_either` as a 2-argument version,
 and add another macro `expect_log_msg_containing_either3` for the
 3-argument version. That way, we can use whichever one we need in future
 tests.
 * I just read `get_interface_address6_via_udp_socket_hack`, and there are
 actually 4 things that can go wrong. So let's cover them all - the extra
 one is:
   * "getsockname() to determine interface failed"
 (I guess that means we need a 4-argument macro
 `expect_log_msg_containing_either4` as well.)

 Can you make these changes, and submit another patch?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20634#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online