[tor-bugs] #20632 [Core Tor/Tor]: Fix error handling in rend_service_parse_port_config()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Nov 11 16:04:51 UTC 2016
#20632: Fix error handling in rend_service_parse_port_config()
--------------------------+------------------------------------
Reporter: twim | Owner:
Type: defect | Status: merge_ready
Priority: Low | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs | Actual Points:
Parent ID: | Points: 0.1
Reviewer: dgoulet | Sponsor: SponsorR-can
--------------------------+------------------------------------
Changes (by dgoulet):
* status: needs_review => merge_ready
* points: => 0.1
* sponsor: => SponsorR-can
* milestone: => Tor: 0.3.0.x-final
* keywords: => tor-hs
* reviewer: => dgoulet
Comment:
That makes the function do extra work when `err_msg_out` is NULL but tbh
I'm fine with it as this function is not called often.
lgtm;
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20632#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list