[tor-bugs] #20533 [Core Tor/Tor]: Each download request should only increment the failure count once

[Tor Bug Tracker & Wiki]

#20533: Each download request should only increment the failure count once
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  regression, CoreTorTeam201611,       |  Actual Points:  0.2
  029-proposed                                   |
Parent ID:  #20499                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  regression => regression, CoreTorTeam201611, 029-proposed
 * version:   => Tor: unspecified
 * actualpoints:   => 0.2


Comment:

 Please see my github branch bug20533_029 for a fix for this issue.

 It does two things:
 * fail a consensus if it expires while we are waiting for certificates for
 it
 * only count a certificate download failure as a consensus schedule
 failure if we actually had a chance to download certificates (currently 1
 minute after requesting certificates)

 The risk in this patch is that we keep trying for certificates, but this
 is unlikely, given that we still stop waiting for certificates for the
 consensus.

 Fix on commit e0204f21 in 0.2.0.9-alpha.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20533#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online