[tor-bugs] #20023 [Applications/Tor Browser]: Upgrade Go to 1.7.3

[Tor Bug Tracker & Wiki]

#20023: Upgrade Go to 1.7.3
----------------------------------------------+----------------------------
 Reporter:  dcf                               |          Owner:  dcf
     Type:  task                              |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-gitian TorBrowserTeam201611R  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by dcf):

 * keywords:  tbb-gitian => tbb-gitian TorBrowserTeam201611R
 * status:  new => needs_review


Comment:

 Here are patches for review. On the maint-6.0 branch, you will need to
 apply both:
  * attachment:0001-Upgrade-Go-to-1.6.3.patch
  * attachment:0002-Bug-20023-Upgrade-Go-to-1.7.3.patch
 On the master branch, you only need:
  * attachment:0002-Bug-20023-Upgrade-Go-to-1.7.3.patch

 For the SDK version issue in comment:8, I opened an upstream issue:
 https://github.com/golang/go/issues/17732. Maybe they can shed some light
 on whether the problematic CFLAGS are intended. In the patches above, my
 workaround is just to patch one file:
 {{{
 sed -i -e '/^#cgo CFLAGS:/s/-D__MAC_OS_X_VERSION_MAX_ALLOWED=1060//'
 crypto/x509/root_cgo_darwin.go
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20023#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online