[tor-bugs] #20523 [Metrics/ExoneraTor]: Use metrics-lib for parsing descriptors

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Nov 1 20:51:23 UTC 2016


#20523: Use metrics-lib for parsing descriptors
--------------------------------+--------------------------------
 Reporter:  karsten             |          Owner:
     Type:  enhancement         |         Status:  needs_revision
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Thanks for looking at the patch and for making those build changes.

 Would you mind making some more changes to that `build.xml`?  (I'm
 terrible at finding the correct Ant commands for all those things.)

  - `src/main/webapp/logging.properties` needs to be included in
 `exonerator.war` as `WEB-INF/classes/logging.properties` (currently
 missing).
  - `src/main/webapp/css/*` need to be included in `exonerator.war` as
 `css/*` (currently in root).
  - `src/main/webapp/images/*` need to be included in `exonerator.war` as
 `images/*` (currently in root).
  - `config` can be omitted from `exonerator.war` (currently in `WEB-
 INF/classes/`)
  - `src/main/resources/db/exonerator.sql` can be omitted from
 `exonerator.war` (currently in `WEB-INF/classes/db/`)
  - Is the `etc` property actually used?
  - Can you include `${libs}/gson-2.2.4.jar` in the classpath (was already
 missing before).

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20523#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list