[tor-bugs] #19044 [Core Tor/Tor]: Turn on --enable-gcc-warnings-advisory by default

[Tor Bug Tracker & Wiki]

#19044: Turn on --enable-gcc-warnings-advisory by default
-------------------------------------------------+-------------------------
 Reporter:  special                              |          Owner:  nickm
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  merge_ready
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Minor                                |  0.2.9.x-final
 Keywords:  TorCoreTeam201605, 029-nickm-says-   |        Version:
  yes                                            |     Resolution:
Parent ID:                                       |  Actual Points:  0.1
 Reviewer:  special                              |         Points:  0.1
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by special):

 * status:  needs_review => merge_ready
 * reviewer:   => special


Comment:

 LGTM. I won't be surprised if we find out that one of these flags isn't
 accepted by all GCC versions and breaks compilation somewhere, but it's
 reasonably defensive about this already.

 We should look at making that list of warnings longer at some point.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19044#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online