[tor-bugs] #18884 [Applications/Tor Browser]: Rip Firefox Hello Beta / Loop extension in ESR45 based Tor Browser

[Tor Bug Tracker & Wiki]

#18884: Rip Firefox Hello Beta / Loop extension in ESR45 based Tor Browser
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
     Type:  task                                 |  arthuredelstein
 Priority:  High                                 |         Status:
Component:  Applications/Tor Browser             |  needs_review
 Severity:  Major                                |      Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605R,     |        Version:
  tbb-6.0-must                                   |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:                                       |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:9 mcs]:
 > When testing with a standalone (non-gitian) build on MacOS, we had to
 add this to the patch:
 > {{{
 > diff --git a/browser/locales/Makefile.in b/browser/locales/Makefile.in
 > index be9454e..ec54b63 100644
 > --- a/browser/locales/Makefile.in
 > +++ b/browser/locales/Makefile.in
 > @@ -133,7 +133,9 @@ ifdef MOZ_WEBAPP_RUNTIME
 >         @$(MAKE) -C ../../webapprt/locales AB_CD=$* XPI_NAME=locale-$*
 >  endif
 >         @$(MAKE) -C ../../extensions/spellcheck/locales AB_CD=$*
 XPI_NAME=locale-$*
 > +ifdef MOZ_LOOP
 >         @$(MAKE) -C ../extensions/loop/chrome/locale AB_CD=$*
 XPI_NAME=locale-$*
 > +endif
 >         @$(MAKE) -C ../../intl/locales AB_CD=$* XPI_NAME=locale-$*
 >         @$(MAKE) -C ../../devtools/client/locales AB_CD=$*
 XPI_NAME=locale-$* XPI_ROOT_APPID='$(XPI_ROOT_APPID)'
 >         @$(MAKE) -B searchplugins AB_CD=$* XPI_NAME=locale-$*
 > }}}

 Thanks for finding this issue. I've added your fix, as well as a second
 one that fixes a problem I ran into with `make package`.

 ​https://github.com/arthuredelstein/tor-browser/commits/18884+7
 Hash f2c8fe1176794a453318e359b08fbf1d618f45d4
 There are two patches as before. I haven't yet tested the new revised
 patches in a full gitian build for 3 platforms, but I'm posting what is
 working for me on OS X.

 > Also, our packaged build still includes the loop extension (but we
 haven't figured out why).
 > {{{
 > ls -l obj-
 macos/dist/firefox/TorBrowserDebug.app/Contents/Resources/browser/features/
 > total 3312
 > -rw-r--r--  1 brade  staff  1691779 May 24 11:39 loop at mozilla.org.xpi
 > }}}

 I'm not seeing this issue. Did you try running `./mach clobber` before
 running `./mach build`?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18884#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online