[tor-bugs] #19132 [Core Tor/Tor]: shared random: missing field 'fetch_missing_votes' initializer

[Tor Bug Tracker & Wiki]

#19132: shared random: missing field 'fetch_missing_votes' initializer
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #16943        |         Points:  0.1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by asn):

 Replying to [comment:2 teor]:
 > If we don't bother, any build on those clang/llvm versions with
 `./configure --enable-gcc-warnings` will fail.
 >
 > So we need to silence this warning, otherwise no-one can use `--enable-
 gcc-warnings` with clang/llvm.

 You are right. I'm surprised this is the only place in the codebase where
 this pattern bothers clang/llvm.

 If this is the only instance of this issue, maybe we can just remove the
 `= {0}` part, and rely on the compiler zeroing it because it's a global
 static struct.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19132#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online