[tor-bugs] #19134 [Core Tor/Tor]: Shared Random: INT_8 means 8 bytes, not 8 bits

[Tor Bug Tracker & Wiki]

#19134: Shared Random: INT_8 means 8 bytes, not 8 bits
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:  #16943        |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by asn):

 Not sure if we should consider this a code bug, or a spec bug. I'm
 personally fine with fitting those fields in a single byte. We are still
 quite far away from anything close to 255 dirauths or 255 SR protocol
 versions.

 I'll let David decide if this is worth the engineering changes. I'm fine
 either way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19134#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online