[tor-bugs] #19126 [Core Tor/Tor]: Consistently use uint64_t for integers in shared random structs (was: Consistently use uint32_t for integers in shared random structs)

[Tor Bug Tracker & Wiki]

#19126: Consistently use uint64_t for integers in shared random structs
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  reopened
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:  0.1
Parent ID:  #16943        |         Points:  0.1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  closed => reopened
 * resolution:  invalid =>


Old description:

> Rather than using int sometimes and uint32_t other times, we could
> consistently use uint32_t in shared random structs.
>
> My branch sr-uint32 at https://github.com/teor2345/tor.git has a fix for
> this.

New description:

 Rather than using int sometimes and uint32_t other times, we could
 consistently use uint64_t in shared random structs.

 Note that reveal_num and version need to be 8 bytes for the SRV hash.

 ~~My branch sr-uint32 at https://github.com/teor2345/tor.git has a fix for
 this.~~

--

Comment:

 Re-opened, but recommend 64 bit now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19126#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online