[tor-bugs] #18616 [Core Tor/Tor]: Make begindir advertise checks consistent with DirPort checks

Mon May 16 19:57:57 UTC 2016

#18616: Make begindir advertise checks consistent with DirPort checks
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  regression, must-fix-before-028-rc,  |        Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-                |  0.2.8.1-alpha
  postponed-201604, review-group-1               |     Resolution:
Parent ID:                                       |  Actual Points:  20
 Reviewer:  arma                                 |  hours
                                                 |         Points:  medium
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 "0.2.8.1-alpha bridges were not advertising begindir support", but:
 * entry_guard_set_status() has a specific bridge check
 * bridge check in add_an_entry_guard
 * no bridge check in router_pick_directory_server_impl, but it's made up
 for by a second check in add_an_entry_guard

 To summarise #18616, the missing bridge begindir support was a bug waiting
 to happen, compensated for by conditionals scattered through the code

 And the other missing checks could have caused subtle bugs too

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online