[tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
--------------------------------------------+------------------------------
 Reporter:  mcs                             |          Owner:
     Type:  defect                          |  arthuredelstein
 Priority:  Medium                          |         Status:  needs_review
Component:  Applications/Tor Browser        |      Milestone:
 Severity:  Normal                          |        Version:
 Keywords:  ff45-esr, TorBrowserTeam201605  |     Resolution:
Parent ID:                                  |  Actual Points:
 Reviewer:                                  |         Points:
                                            |        Sponsor:
--------------------------------------------+------------------------------
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:15 gk]:
 > Neat idea and I guess Mozilla would even be amenable to take that patch.
 However, that still does not seem enough. I stumbled over another Pocket
 button while looking at the Reader functionality (see:
 https://mxr.mozilla.org/mozilla-
 esr45/source/browser/modules/ReaderParent.jsm#81). There are even more
 instances of `CustomizableUI.getPlacementOfWidget("pocket-button")` we
 might want to take care of when upstreaming (even though I did not figure
 out how to get a related Pocket button shown in Tor Browser for these
 cases).

 Thanks for pointing these out. Here is a new version that takes care of
 the pocket button in Reader Mode and also the unlikely event of Pocket
 items in the context menu.

 https://github.com/arthuredelstein/tor-browser/commit/18886+4
 Hash c3fc62020f4b12aaa633d5760ea77999a97c5f11

 I haven't modified the UITour code as we are already suppressing the
 UITour itself.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18886#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online