[tor-bugs] #17158 [Core Tor/Tor]: Run an opt-in process for fallback directories

[Tor Bug Tracker & Wiki]

#17158: Run an opt-in process for fallback directories
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  merge_ready
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  028-triaged, must-fix-               |        Version:
  before-028-rc, TorCoreTeam201605,              |     Resolution:
  TorCoreTeam-postponed-201604, review-group-1   |  Actual Points:  3 weeks
Parent ID:                                       |         Points:  small-
 Reviewer:  isis                                 |  remaining
                                                 |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:43 teor]:
 > Replying to [comment:42 isis]:
 > >
 > I'd like to fix these issues - see my branch fallback-script on
 https://github.com/teor2345/tor.git

 Okay, all the fixes work for me.


 > >  * Do we want to raise these cutoffs now?
 > > {{{
 > > # Reduced due to a bug in tor where a relay submits a 0 DirPort when
 restarted
 > > # This causes OnionOO to (correctly) reset its stability timer
 > > # This issue will be fixed in 0.2.7.7 and 0.2.8.2
 > > # Until then, the CUTOFFs below ensure a decent level of stability.
 > > ADDRESS_AND_PORT_STABLE_DAYS = 7
 > > }}}
 >
 > Sadly, no, there's no 0.2.7.7 yet. And 0.2.6 - 0.2.4 relays are still
 affected by that bug.
 > I've put it on the list of things to review for the 0.2.9 fallback list
 in #18828.

 Ack, makes sense.

 > >  * I get a bunch of these warnings: `WARNING::Consensus download:
 23.1s too slow from IPredator (197.231.221.211:9030), max download time
 15.0s.` for various relays which, like iPredator, I know are fast. (It's
 obvious this is due to my running the script through `torsocks`, but it
 wasn't clear to me that I shouldn't do that. It also seems odd to have the
 cutoff time hardcoded to 15s, since for all I (or the script) know, my
 roommate could be torrenting a bunch of anime and oopsies now it picks
 completely different fallbacks.)
 >
 > I had this issue as well when developing the script, my internet
 connection drops speed sometimes.
 >
 > I wrote a comment about needing a good network connection at the top of
 the script, or disabling the consensus download checks.
 >
 > 46d8139  Improve comments in fallback update script
 >
 > The script also retries failed downloads, to avoid excluding a fallback
 due to transient network issues.
 >
 > I'm not sure what else could be done - do you think we should compare
 the entire set of times, and exclude those that are way too high?
 >
 > But that still doesn't address transient network issues.
 >

 Meh, I think it's fine to just include the comment at the top that says
 you shouldn't be running it on a flaky network.

 > >
 > > Replying to [comment:41 teor]:
 > > > (This has been merged to maint-0.2.8 and can be closed after review
 if there are no issues.)
 > >
 > > Overall the script LGTM. I'm willing to call this done.
 >
 > Then let's merge and close if you're happy with the cosmetic changes.

 Changing to merge_ready. Thanks, teor!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17158#comment:47>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online