[tor-bugs] #18809 [Core Tor/Tor]: Handle linked connections better during bootstrap

[Tor Bug Tracker & Wiki]

#18809: Handle linked connections better during bootstrap
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  Medium                               |  assigned
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,              |        Version:  Tor:
  TorCoreTeam201605                              |  0.2.8.1-alpha
Parent ID:                                       |     Resolution:
 Reviewer:  teor                                 |  Actual Points:
                                                 |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Replying to [comment:8 dgoulet]:
 >   DG1: Just after we set `answer = 1`, we should break. There is no need
 to continue the loop.

 Sounds good. I've pushed another commit that does this.

 > * Commit `a9012a61fafae3ca8c6ae40ba5f433dcf12aad71`
 >
 >   DG2: There is an awful lot of code removal in there but the commit
 message doesn't tell me why nor what is being removed here. This is an
 interesting change, we go from a callback every second trying to cleanup
 to a function call only done when we successfully receive a consensus.

 Yes, correct. The comments for the new
 connection_dir_close_consensus_fetches() function are probably the best
 description of what's going on here. Should I try to clarify more?

 > The whole logic of this patch seems OK to me. Let's fix those unit tests
 :).

 If somebody wants to grab this and fix the unit tests, please do. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18809#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online